[Carthage] Added shared framework scheme#207
Open
ha1f wants to merge 2 commits intogilesvangruisen:masterfrom
Open
[Carthage] Added shared framework scheme#207ha1f wants to merge 2 commits intogilesvangruisen:masterfrom
ha1f wants to merge 2 commits intogilesvangruisen:masterfrom
Conversation
ha1f
changed the title
ha1f
changed the title
ha1f
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #206
This Pull-Request contains 2 bug fixes.
1. Added shared framework scheme to build with carthage
shared scheme is required for carthage.
2. Do not embed swift standard libraries
This change was added with this commit
This will cause
Assertion failed: Duplicate symbols for xxxerror to build ipa of the application.(Since
libswiftCore.dylibwill present under this framework and application.)