Add Support for the Swift Package Manager#215
Open
vincentthe0ne wants to merge 2 commits intogilesvangruisen:masterfrom
Open
Add Support for the Swift Package Manager#215vincentthe0ne wants to merge 2 commits intogilesvangruisen:masterfrom
vincentthe0ne wants to merge 2 commits intogilesvangruisen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since SPM supports Resource processing in its newer version, I was able to add Support to SPM for your Framework.
I've tested everything through the command
swift testand resolved every Error.To Support the loading of the
YTPlayer.htmlit was necessary to implement theBundle.moduleinstead of theBundle(for: YouTubePlayerView.self)which would lead to a crash while running an application with the YouTubePlayer.The Tests are just added to satisfy the command line tool so I haven't implemented any tests.
I've uploaded a little test application to prove that the SPM Support is working. There also is a simple SwiftUI Example integrated.
https://github.com/vincentthe0ne/SPMYouTubePlayerTest
With this MR the #215 will be solved.