read: error message improvements#865
Merged
philipc merged 3 commits intogimli-rs:masterfrom Jan 21, 2026
Merged
Conversation
Try to make errors more concise and consistent, and report values where possible.
CrooseGit
added a commit
to CrooseGit/thorin
that referenced
this pull request
Feb 26, 2026
- `gimli` reworded their error messages in gimli-rs/gimli#865 - These changes landed in the 0.33.0 release of `gimli` - Since `thorin` has upgraded to the latest `gimli`, the tests expecting particular error messages needed updating.
CrooseGit
added a commit
to CrooseGit/thorin
that referenced
this pull request
Feb 26, 2026
- `gimli` reworded their error messages in gimli-rs/gimli#865 - These changes landed in the 0.33.0 release of `gimli` - Since `thorin` has upgraded to the latest `gimli`, the tests expecting particular error messages needed updating.
davidtwco
pushed a commit
to rust-lang/thorin
that referenced
this pull request
Feb 27, 2026
- `gimli` reworded their error messages in gimli-rs/gimli#865 - These changes landed in the 0.33.0 release of `gimli` - Since `thorin` has upgraded to the latest `gimli`, the tests expecting particular error messages needed updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #463. Partially addresses #717