Skip to content

Conversation

iamritikbhardwaj
Copy link

@iamritikbhardwaj iamritikbhardwaj commented Jun 27, 2025

There was this issue that the multipart form is not cleaned after req completion

// CleanUp clean up the multipart request
func (r *multipartRequest) CleanUp() error {
	if r.MultipartForm != nil {
		return r.MultipartForm.RemoveAll()
	}
	return nil
}

this fixes #4278

@FarmerChillax
Copy link
Contributor

I don't think this is the optimal solution

@iamritikbhardwaj
Copy link
Author

I don't think this is the optimal solution

Any other suggestions 🤔

@FarmerChillax
Copy link
Contributor

I don't think this is the optimal solution

Any other suggestions 🤔

The current usage scenario does not seem clear. I think we should first understand the scenario and then design a plan

@iamritikbhardwaj
Copy link
Author

I don't think this is the optimal solution

Any other suggestions 🤔

The current usage scenario does not seem clear. I think we should first understand the scenario and then design a plan

Okay please let me know if a discussion is required as i am a fresher looking to learn things from experienced people.

@FarmerChillax
Copy link
Contributor

I don't think this is the optimal solution

Any other suggestions 🤔

The current usage scenario does not seem clear. I think we should first understand the scenario and then design a plan

Okay please let me know if a discussion is required as i am a fresher looking to learn things from experienced people.

There are related discussions in the issue, welcome to participate and put forward your own opinions

@iamritikbhardwaj iamritikbhardwaj closed this by deleting the head repository Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why no call to Request.MultipartForm.RemoveAll
2 participants