Feat: Add Http headers constants#4474
Open
YlanzinhoY wants to merge 3 commits intogin-gonic:masterfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
- Coverage 99.21% 98.99% -0.22%
==========================================
Files 42 44 +2
Lines 3182 2986 -196
==========================================
- Hits 3157 2956 -201
- Misses 17 21 +4
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anfaas1618
reviewed
Dec 22, 2025
| ```go | ||
|
|
||
| const ( | ||
| HeaderAuthorization string = "Authorization" |
There was a problem hiding this comment.
can we not make a type here named
type Header stringand use
const (
HeaderAuthorization Header = "Authorization"
...
)|
link this to a issue please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added header constants for type safety and to avoid writing anything wrong.
I believe it's a good addition to the codebase, since competing frameworks also have this kind of thing.
This feature maintains backward compatibility, allowing those who want to write in a pure way to continue, and those who want to use constants to use them as well.
example
Please ensure your pull request meets the following requirements:
masterbranch.docs/doc.md.