Tifffile _biggestSeries() bug for large images#1547
Open
Dany546 wants to merge 1 commit intogirder:masterfrom
Open
Tifffile _biggestSeries() bug for large images#1547Dany546 wants to merge 1 commit intogirder:masterfrom
Dany546 wants to merge 1 commit intogirder:masterfrom
Conversation
Member
|
Do you have an example image where it fails? If it can't be shared, can the output of I don't understand why the sqrt of the shape product would be desirable. The intent is that the main series would be the series with the most total pixels. If it is overflowing do to data types, a better choice might be to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _biggestSeries() method used to read tifffile sources rely on np.prod(shape) to find the biggest series in the file (macro image > image). This leads to an overflow for big images and the macro image is wrongly selected as the main content of the file. Simple fix is done with np.sqrt(), though a better solution could be found.