-
Notifications
You must be signed in to change notification settings - Fork 49
New UI for creating and editing views #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeffbaumes
wants to merge
785
commits into
v3-experimental-integration
Choose a base branch
from
edit-views-ui
base: v3-experimental-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffbaumes
commented
Sep 26, 2024
- Updated styling to use tailwind. Requires Style update (experimental) girder#3570.
- New UI for updating the columns to show in the item list view. Created/copied views are scoped to the current user.
Member
|
@jeffbaumes Can you rebase or merge master into this branch? The |
Guard isGeopatial when called on an image GDAL can open but not read
This does a better job of selecting multi-frame sources
Tweak a few source priorities
We were only checking the first "few" elements to see if they were large enough that we had to store them as files rather than in the database, and we were not checking the size of holes in polygons. As such, an annotation element with a huge number of holes, or one with many small polygons followed by a huge polygon could fail to be placed in the database. Further, insert errors of this sort were not being percolated up to the logs, making debug difficult.
Improve handling of large annotation elements
Prefer openslide to read czi files if possible
Update a test to handle variations in openslide
If multiple dicom files from the same series and study are uploaded or imported to the same folder, and the option is selected, all of the files will be moved to a single item (the first so located). This makes browsing WSI dicoms easier, as they appear as single items, but may have repercussions. This feature should be viewed as provisional until tested more thoroughly in the field.
Add an option to merge dicom files in the same series and study
Remove spacing that triggers blockquoting
The tiff source should always be preferred for a file with a tiff extension
Change some source priorities for tiff
Make casing in slim.Dockerfile more consistent
This greatly reduces serialization time and web traffic.
In many instances, save annotation element via a PATCH call
Reduce a warning message that should no longer be of interest
When zoomed in with a power of two of the max zoom and showing annotations, make sure all of the annotation in view are fully loaded. Before, this was still subject to detail limits, which meant that it was possible to fail to resolve some annotations regardless of zoom level.
Show all annotations when zoomed in
Guard against nd2 NotImplementedError and allow bioformats to handle nd2
Handle editing paged annotations.
Log when we skip annotations that are too big.
Increase the maximum number of annotation elements in data plot
Add more mimetypes
To allow clients to do less work when reloading models, make it easier to rebind annotation models.
Make it easier to rebind annotation models
This was a type. This also affects ellipses
Fixed an issue emitting geojson annotations with rotated rectangles
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…s/checkout-6 Bump actions/checkout from 5 to 6
Fix a typo in a comment in the test.Dockerfile
Update pre-commit hook versions
Change how delattr is used when del can be used.
Satisfy bugbear rule 043.
Add support for patterned polygon annotations
…server` function
In Jupyter, set edge value of tilesource to transparent
This doesn't yet support everything, since rasterio, umap-learn, and rawpy aren't available yet. Also, the zarr concurrency test fails.
Add Python 3.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.