Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/girlscript-blr/build-with-gsblr-raahat/mtdtr3v0o |
smilegupta
left a comment
smilegupta
left a comment
There was a problem hiding this comment.
Also please prettify the code if possible! Using prettier extension!
| return ( | ||
| <div> | ||
| <Router> | ||
| <Switch> | ||
| <Route path="/" exact component={Header}/> | ||
| <Route path="/" exact component={footer}/> | ||
| </Switch> | ||
| </Router> |
There was a problem hiding this comment.
Its not the correct.
- Routing is all about different pages!
- Footer Component will come below the outside Switch Tag!
- For more details, Refer how to do routing in this video! https://www.youtube.com/watch?v=Law7wfdg_ls&t=1778s
- F for footer will be capitalized
There was a problem hiding this comment.
I have corrected
- F capital in footer component.
- Outside switch tag added route path with /Footer so is this correct ?
There was a problem hiding this comment.
Hey @smilegupta I changed the code but am stuck in the pr. I dont know why its having every new pr while commiting the code.
There was a problem hiding this comment.
@karshil2309 what exactly are facing issue!? Can you brief more about it.
There was a problem hiding this comment.
@smilegupta I have done the changes but I did some blunders with git. So may be my code hasnt been updated. Can I do new PR and update it ?
src/components/Footer/footer.js
Outdated
|
|
||
|
|
||
|
|
||
| function footer() { |
There was a problem hiding this comment.
F should be capitalised for this fuction name!
|
@smilegupta Please review PR done the changes |
girlscript-blr
left a comment
girlscript-blr
left a comment
There was a problem hiding this comment.
I see that the footer created is not properly aligned with the provided wireframe. Please do the needful changes.
Also we see that you have raised one more PR #31 . Either do the final changes on this or the other PR.
src/components/Footer/footer.js
Outdated
| <a | ||
| href="https://www.facebook.com/" | ||
| className="facebook social" | ||
| > | ||
| <FontAwesomeIcon icon={faFacebook} size="5x" /> | ||
| </a> | ||
| <a | ||
| href="https://www.linkedin.com/" | ||
| className="linkedin social" | ||
| > | ||
| <FontAwesomeIcon icon={faLinkedin} size="5x" /> | ||
| </a> | ||
| <a | ||
| href="https://www.telegram.com/" | ||
| className="telegram social" | ||
| > | ||
| <FontAwesomeIcon icon={faTelegram} size="5x" /> | ||
| </a> | ||
|
|
||
| <a | ||
| href="https://www.instagram.com/" | ||
| className="instagram social" | ||
| > | ||
| <FontAwesomeIcon icon={faInstagram} size="5x" /> | ||
| </a> | ||
| <a | ||
| href="https://www.medium.com/" | ||
| className="medium social" | ||
| > | ||
| <FontAwesomeIcon icon={faMedium} size="5x" /> | ||
| </a> |
There was a problem hiding this comment.
Please add the following properties to the <a> tags to remove warnings:
- target="_blank"
- rel="noopener noreferrer"
There was a problem hiding this comment.
Do you need any help? You are the last guy whose PR is not got accepted?
There was a problem hiding this comment.
Yes please, while adding the background color, the page is not looking as per design.
4 participants
Updated the footer code. Please check. Thank you!!!