Skip to content

Stop using use vars#4

Open
guillemj wants to merge 3 commits intogisle:masterfrom
guillemj:pu/no-use-vars
Open

Stop using use vars#4
guillemj wants to merge 3 commits intogisle:masterfrom
guillemj:pu/no-use-vars

Conversation

@guillemj
Copy link

This series switches the code away from use vars to modern alternatives, including using parent, and importing Exporter's import directly.

guillemj added 3 commits July 13, 2017 04:38
This is one of the modern forms to get at the import. Use it instead of
inheriting from Exporter and using the deprecated «use vars».
This is the modern form of inheriting from another module. Use it
instead of inheriting via @isa and using the deprecated «use vars».
The former is deprecated and has a non-insignificant cost of loading a
module.
Copy link

@shlomif shlomif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 .

@toddr
Copy link

toddr commented Aug 24, 2021

This happened in commit 1cd2105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants