Parse internal DTDs in doctype declaration#10
Open
paulbijnens wants to merge 4 commits intogisle:masterfrom
Open
Parse internal DTDs in doctype declaration#10paulbijnens wants to merge 4 commits intogisle:masterfrom
paulbijnens wants to merge 4 commits intogisle:masterfrom
Conversation
Author
|
Wait a moment -- still some bug. |
Author
|
Ok. Now it correctly parses all the possible ways comments inside the internal DTD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to now it was documented that internal DTDs inside the doctype declaration confuse HTML::Parser.
Depending on the content of that internal dtd, the parser would return a text token instead, but sometimes also a declaration token that contained a lot of elements and text appearing after the syntactically correct declaration as well.
The old implementation did allow for the empty internal DTD like:
<!DOCTYPE abc SYSTEM "abc.dtd" [] >This patch allows non-empty internal DTDs inside those square brackets in the doctype declaration, and returns the whole internal DTD as one single token in the list, similar to the token just containing "
[]" in the old implementation. E.g. now it correctly parses:Paul
(Ten years after my previous small patch, but still using this very nice perl module, one of the only ones that allows for sane parsing of sgml-like files with errors in it.)