default OAuth redirect URI to http://127.0.0.1 (#1444)

mjcheetham · web-flow · commit e5495867fb44 · 2023-10-24T10:20:48.000-07:00
diff --git a/docs/generic-oauth.md b/docs/generic-oauth.md
@@ -40,7 +40,7 @@ following values in your Git configuration:
 
 - Client ID
 - Client Secret (optional)
-- Redirect URL
+- Redirect URL (optional, defaults to `http://127.0.0.1`)
 - Scopes (optional)
 - OAuth Endpoints
   - Authorization Endpoint
diff --git a/src/shared/Core/GenericOAuthConfig.cs b/src/shared/Core/GenericOAuthConfig.cs
@@ -104,9 +104,7 @@ public static bool TryGet(ITrace trace, ISettings settings, InputArguments input
 
             if (config.RedirectUri == null)
             {
-                trace.WriteLine($"Invalid OAuth configuration - missing/invalid redirect URI: {redirectUrl}");
-                config = null;
-                return false;
+                config.RedirectUri = new Uri("http://127.0.0.1");
             }
 
             if (settings.TryGetSetting(

Original file line number	Diff line number	Diff line change
`@@ -104,9 +104,7 @@ public static bool TryGet(ITrace trace, ISettings settings, InputArguments input`
`104`	`104`
`105`	`105`	`if (config.RedirectUri == null)`
`106`	`106`	`{`
`107`		`- trace.WriteLine($"Invalid OAuth configuration - missing/invalid redirect URI: {redirectUrl}");`
`108`		`- config = null;`
`109`		`- return false;`
	`107`	`+ config.RedirectUri = new Uri("http://127.0.0.1");`
`110`	`108`	`}`
`111`	`109`
`112`	`110`	`if (settings.TryGetSetting(`