Skip to content

Remove misleading error message #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove misleading error message #1694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/shared/GitLab/GitLabHostProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ public override bool IsSupported(InputArguments input)
return false;
}

// We do not support unencrypted HTTP communications to GitLab,
// but we report `true` here for HTTP so that we can show a helpful
// error message for the user in `CreateCredentialAsync`.
if (!StringComparer.OrdinalIgnoreCase.Equals(input.Protocol, "http") &&
!StringComparer.OrdinalIgnoreCase.Equals(input.Protocol, "https"))
{
Expand Down Expand Up @@ -94,13 +91,6 @@ public override async Task<ICredential> GenerateCredentialAsync(InputArguments i
{
ThrowIfDisposed();

// We should not allow unencrypted communication and should inform the user
if (StringComparer.OrdinalIgnoreCase.Equals(input.Protocol, "http"))
{
throw new Trace2Exception(Context.Trace2,
"Unencrypted HTTP is not supported for GitHub. Ensure the repository remote URL is using HTTPS.");
}

Uri remoteUri = input.GetRemoteUri();

AuthenticationModes authModes = GetSupportedAuthenticationModes(remoteUri);
Expand Down