Skip to content

Conversation

@mjcheetham
Copy link
Contributor

If we have a repo nickname value present in the trace2.param.set, then emit this as a process span attribute directly "trace2.repo.nickname". This will make it easier to make decisions on routing of these traces in the collector, without having to resort to parsing the trace2.param.set JSON object.

If we have a repo nickname value present in the trace2.param.set, then
emit this as a process span attribute directly "trace2.repo.nickname".
This will make it easier to make decisions on routing of these traces in
the collector, without having to resort to parsing the trace2.param.set
JSON object.

Signed-off-by: Matthew John Cheetham <[email protected]>
Copy link
Contributor

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mjcheetham mjcheetham merged commit 576ec02 into main Nov 20, 2025
9 checks passed
@mjcheetham mjcheetham deleted the nickname branch November 20, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants