Skip to content

Commit 574e8c3

Browse files
committed
make-file-list: work around a libunistring version problem of gnupg
As of yesterday's big MSYS2 i686 sync, there is no longer an `msys-unistring-2.dll` but an `msys-unistring-5.dll`. However, gnupg (e.g. `dirmngr.exe`, via `msys-gnutls-30.dll`) depends on the former file to be present. Since the full i686 variant of Git for Windows is on its way out (we'll be dropping the installer/portable Git builds for i686 after one last full i686 release with Git for Windows v2.48.1, and MinGit does not include gnupg), it isn't worth fretting too much about this; Simply copying the latter to the former seems to work just fine. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 1a72bc6 commit 574e8c3

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

make-file-list.sh

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,10 +404,22 @@ usr/bin/dash.exe
404404
usr/bin/getopt.exe
405405
EOF
406406

407+
EXTRA_DLL_FILES=
407408
case $MSYSTEM_LOWER in
408409
mingw*)
409410
PDFTOTEXT_FILES="$MSYSTEM_LOWER/bin/pdftotext.exe
410411
$MSYSTEM_LOWER/bin/libstdc++-6.dll"
412+
if test i686 = "$ARCH" &&
413+
grep msys-unistring-2 /usr/bin/msys-gnutls-30.dll 2>&1 >/dev/null &&
414+
test ! -d /var/lib/pacman/local/libunistring-0*-1
415+
then
416+
# Utter hack: i686 gnupg might still link to msys-unistring-2.dll
417+
test -f /usr/bin/msys-unistring-2.dll ||
418+
cp /usr/bin/msys-unistring-5.dll /usr/bin/msys-unistring-2.dll ||
419+
die "Could not fudge msys-unistring-2.dll"
420+
EXTRA_DLL_FILES='
421+
usr/bin/msys-unistring-2.dll'
422+
fi
411423
;;
412424
*)
413425
# In the clang version, we do not need the libstdc++ DLL
@@ -421,7 +433,7 @@ etc/post-install/01-devices.post
421433
etc/post-install/03-mtab.post
422434
etc/post-install/06-windows-files.post
423435
usr/bin/start
424-
$PDFTOTEXT_FILES
436+
$PDFTOTEXT_FILES$EXTRA_DLL_FILES
425437
usr/bin/column.exe
426438
EOF
427439

0 commit comments

Comments
 (0)