Skip to content

Fix check for missing dlls#674

Merged
dscho merged 3 commits intomainfrom
fix-check-for-missing-dlls
Jan 27, 2026
Merged

Fix check for missing dlls#674
dscho merged 3 commits intomainfrom
fix-check-for-missing-dlls

Conversation

@dscho
Copy link
Member

@dscho dscho commented Jan 27, 2026

This addresses the problems reported in the x64 and in the x86.

dscho added 3 commits January 27, 2026 14:01
… too

Git Credential Manager now ships for all the architectures we need in
Git for Windows: x86, x64 and arm64. Therefore, the distributed
binaries include the architecture-specific MSAL runtime DLLs, which we
need to accommodate for.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The `msys-smartcols-1.dll` file is included in the `libutils-linux`
package, but it is only a dependency of `cfdisk.exe`, `column.exe`,
`fdisk.exe`, `sfdisk.exe`, `uuidparse.exe`, and `wipefs.exe`, none of
which are included in Git for Windows.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
As the new `mingw-w64-git-svn` package is a new dependency of the
`mingw-w64-git-for-windows-addons` package, we need to be a bit more
verbose when excluding files from MinGit, as pointed out by the Git for
Windows SDKs' `check-for-missing-dlls` workflow runs.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho requested review from mjcheetham and rimrul January 27, 2026 13:03
@dscho dscho self-assigned this Jan 27, 2026
@dscho dscho marked this pull request as ready for review January 27, 2026 13:11
@dscho dscho merged commit 9d07c21 into main Jan 27, 2026
21 checks passed
@dscho dscho deleted the fix-check-for-missing-dlls branch January 27, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants