Skip to content

Conversation

jeremyd2019
Copy link
Contributor

Calls pacman-helper.sh quick_remove.

For git-for-windows/git-sdk-32#39 (comment)

@dscho
Copy link
Member

dscho commented Feb 19, 2025

@jeremyd2019 I adjusted this PR branch according to the changes I made in git-for-windows/build-extra#597 (commits). What do you think? If you're okay with these changes, I'll auto-squash them and merge.

@dscho
Copy link
Member

dscho commented Feb 19, 2025

Naturally, this can only be merged after git-for-windows/build-extra#597.

According to git-for-windows/MSYS2-packages#218 (comment), the first order of business after merging this here PR will be to run the workflow to remove these packages:

ca-certificates-i686 cyrus-sasl-i686 docbook-xsl-ns-i686 gzip-i686 less-i686 libksba-i686 libksba-devel-i686 libsasl-i686 libsasl-devel-i686 libserf-i686 libserf-devel-i686 libssh2-i686 libssh2-devel-i686 nano-i686 vim-i686 zlib-i686 zlib-devel-i686

Sound about right?

@jeremyd2019
Copy link
Contributor Author

sounds right

Git for Windows relies on MSYS2 for a lot of packages, but also provides
some packages of its own. Sometimes, Git for Windows even overrides
(or "shadows") MSYS2's packages. And sometimes Git for Windows needs to
stop overriding such packages.

This new GitHub workflow allows for stopping to override MSYS2 packages
by calling the shiny new `pacman-helper.sh quick_remove` functionality
added in git-for-windows/build-extra#597.

This will be used to clean up Git for Windows' Pacman repository after
the most recent batch of MSYS2 updates to its i686 repository, see
git-for-windows/git-sdk-32#39 (comment)
for full details.

Co-authored-by: Johannes Schindelin <[email protected]>
Signed-off-by: Jeremy Drake <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho merged commit f054802 into git-for-windows:main Feb 20, 2025
@dscho
Copy link
Member

dscho commented Feb 20, 2025

Huh. Looks as if the makepkg-git flavor of Git for Windows' SDK is not good enough? At least when I tried to run the workflow, it failed:

gpg: directory '/d/a/_temp/home/.gnupg' created
gpg: error running '/usr/bin/dirmngr': probably not installed
gpg: failed to start dirmngr '/usr/bin/dirmngr': Configuration error
gpg: can't connect to the dirmngr: Configuration error
gpg: keyserver receive failed: No dirmngr

Will try with build-installers.

@dscho
Copy link
Member

dscho commented Feb 20, 2025

This worked, so I opened #115.

@jeremyd2019
Copy link
Contributor Author

ah, ok. I was looking to make sure the necessary bits for repo-remove were there, I didn't think that parts of gpg would be missing

@jeremyd2019 jeremyd2019 deleted the remove-packages-action branch February 20, 2025 18:13
@dscho
Copy link
Member

dscho commented Feb 21, 2025

ah, ok. I was looking to make sure the necessary bits for repo-remove were there, I didn't think that parts of gpg would be missing

FWIW I was convinced that the gpg/dirmngr parts were part of the makepkg-git flavor of Git for Windows' SDK, too. But the scientific method taught me differently ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants