Skip to content

Conversation

dscho
Copy link
Member

@dscho dscho commented Mar 11, 2025

We already do that in the git-artifacts workflows in the git-sdk-* repositories, so it is only logical to do the same in the git-artifacts workflow in git-for-windows-automation.

Note: I copy/edited the version from the git-sdk-arm64 repository's git-artifacts workflow because that is quite a bit ahead of the other git-sdk-* repositories' versions.

@dscho dscho self-assigned this Mar 11, 2025
@dscho
Copy link
Member Author

dscho commented Mar 11, 2025

Hmm. Due to GitHub Actions' insistence on loading only chunks of the log, the grouping around the (lengthy!) installer.log is pretty useless. Without forcing Actions' web UI to scroll to the end (which can take ages, thanks to said chunk-wise-only loading), one cannot even see the output of the validation.

So maybe we should drop the part that prints the installer.log to the workflow run's log. The installer.log file is uploaded as a workflow artifact, anyway.

We already do that in the `git-artifacts` workflows in the `git-sdk-*`
repositories, so it is only logical to do the same in the
`git-artifacts` workflow in `git-for-windows-automation`.

Note: I copy/edited the version from the `git-sdk-arm64` repository's
`git-artifacts` workflow because that is quite a bit ahead of the other
`git-sdk-*` repositories' versions.

There is one notable deviation from that workflow: The `installer.log`
file is no longer shown in the workflow run's log. The reason is: it is
lengthy, and the grouping does not work due to GitHub's web UI
implementation. GitHub's web UI insists on loading only a small chunk of
the logs at a time, missing the end of the group, and simply not showing
the relevant part (which comes after the log). The `installer.log` file
is uploaded as an artifact anyway, so not much is lost.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the validate-installers-in-git-artifacts branch from d29cdbc to d9bdd27 Compare March 12, 2025 11:22
@dscho
Copy link
Member Author

dscho commented Mar 12, 2025

I took out the installer.log from the log, and started test runs for i686 (which promptly reminded me that Git for Windows no longer supports i686 installers) and aarch64 (since the workflow overwrites any existing git-artifacts Check Runs in git-for-windows/git, I targeted a different git-for-windows/git commit than the tip commit).

Yesterday, I already triggered the x86_64 test run (which still printed installer.log's contents to the log, but was otherwise identical to the current PR branch, and concluded successfully).

@dscho
Copy link
Member Author

dscho commented Mar 12, 2025

It also worked well for aarch64. So I'll mark this as ready to review.

@dscho dscho marked this pull request as ready for review March 12, 2025 15:44
Copy link
Contributor

@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice setup! ✨

@dscho dscho merged commit a7a02f1 into main Mar 12, 2025
5 of 6 checks passed
@dscho dscho deleted the validate-installers-in-git-artifacts branch March 12, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants