Azure self-hosted runners: show logs on failure #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
approved these changes
Sep 25, 2024
|
|
||
| - name: Show some more information on failure | ||
| if: failure() | ||
| uses: azure/cli@v2 |
There was a problem hiding this comment.
Elsewhere, we moved away from Azure/CLI, maybe we can do that here, too?
dennisameling
force-pushed
the
logging-on-vm-creation-failure
branch
2 times, most recently
from
91041db to
d1e7797
Compare
We currently depend on the azure/login GitHub Action in various places. It simply runs an "az login" and "az account set" behind the scenes, and has support for plenty of other scenarios. As we're moving away from azure/cli in more and more places, we could also replace the login script with our own. Let's create a Composite Workflow to achieve this goal. Signed-off-by: Dennis Ameling <[email protected]>
We now have our own simple workflow to log into Azure, using "az login". As we're moving way from things like the Azure CLI, let's also start using our own login script instead. Signed-off-by: Dennis Ameling <[email protected]>
We're seeing intermittent `OSProvisioningTimedOut` errors on VM creation, which typically happens within 20-40 mins of the deployment hanging. Let's try and find out what's going wrong, so we can see if we need to fix things on our end. Ref: https://github.com/git-for-windows/git-for-windows-automation/actions/runs/11025772033/job/30621189230 Signed-off-by: Dennis Ameling <[email protected]>
Even if the deployment of a runner failed, we'd like to see the post-deployment script output. Maybe something failed there. This is under the assumption that the azure/arm-deploy action will output the information, even if the deployment failed. Let's see if it works. Signed-off-by: Dennis Ameling <[email protected]>
The azure/cli action runs in a Docker container that only has a very limited subset of tools compared to the GitHub Actions runners. Luckily, the Azure CLI comes pre-installed with Hosted Runners. Let's use use it directly, so we can enjoy all the other tools that it offers. Signed-off-by: Dennis Ameling <[email protected]>
We now have our own simple workflow to log into Azure, using "az login". As we're moving way from things like the Azure CLI, let's also start using our own login script instead. Signed-off-by: Dennis Ameling <[email protected]>
dennisameling
force-pushed
the
logging-on-vm-creation-failure
branch
from
65c2212 to
ab3fad1
Compare
|
@dscho I've updated the PR to move away from the So I'd be OK to keep using Also, here's a successful workflow run with the new setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing intermittent
OSProvisioningTimedOuterrors on VM creation, which typically happens within 20-40 mins of the deployment hanging. Most creation jobs seem to work fine, though.Let's try and find out what's going wrong, so we can see if we need to fix things on our end.