Skip to content

Commit 3c14419

Browse files
peffgitster
authored andcommitted
t/lib-httpd: enable HTTP/2 "h2" protocol, not just h2c
Commit 73c49a4 (t: run t5551 tests with both HTTP and HTTP/2, 2022-11-11) added Apache config to enable HTTP/2. However, it only enabled the "h2c" protocol, which allows cleartext HTTP/2 (generally based on an upgrade header during an HTTP/1.1 request). This is what t5559 is generally testing, since by default we don't set up SSL/TLS. However, it should be possible to run t5559 with LIB_HTTPD_SSL set. In that case, Apache will advertise support for HTTP/2 via ALPN during the TLS handshake. But we need to tell it support "h2" (the non-cleartext version) to do so. Without that, then curl does not even try to do the HTTP/1.1 upgrade (presumably because after seeing that we did TLS but didn't get the ALPN indicator, it assumes it would be fruitless). Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9d15b1e commit 3c14419

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/lib-httpd/apache.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ ErrorLog error.log
3131

3232
<IfDefine HTTP2>
3333
LoadModule http2_module modules/mod_http2.so
34-
Protocols h2c
34+
Protocols h2 h2c
3535
</IfDefine>
3636

3737
<IfVersion < 2.4>

0 commit comments

Comments
 (0)