Skip to content

Commit 5cd3e10

Browse files
robbat2gitster
authored andcommitted
Fix false positives in t3404 due to SHELL=/bin/false
If the user's shell in NSS passwd is /bin/false (eg as found during Gentoo's package building), the git-rebase exec tests will fail, because they call $SHELL around the command, and in the existing testcase, $SHELL was not being cleared sufficently. This lead to false positive failures of t3404 on systems where the package build user was locked down as noted above. Signed-off-by: "Robin H. Johnson" <[email protected]> X-Gentoo-Bug: 349083 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=349083 Signed-off-by: Junio C Hamano <[email protected]>
1 parent 26517de commit 5cd3e10

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

t/t3404-rebase-interactive.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,9 @@ test_expect_success 'setup' '
6767
# "exec" commands are ran with the user shell by default, but this may
6868
# be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
6969
# to create a file. Unseting SHELL avoids such non-portable behavior
70-
# in tests.
70+
# in tests. It must be exported for it to take effect where needed.
7171
SHELL=
72+
export SHELL
7273

7374
test_expect_success 'rebase -i with the exec command' '
7475
git checkout master &&

0 commit comments

Comments
 (0)