Skip to content

Commit c43b7e6

Browse files
avargitster
authored andcommitted
perf aggregate: remove GIT_TEST_INSTALLED from --codespeed
Remove the setting of the "environment" from the --codespeed output. I don't think this is useful, and it helps with a later refactoring where we GIT_TEST_INSTALLED stop munging/reading GIT_TEST_INSTALLED in the perf tests in so many places. This was added in 05eb1c3 ("perf/aggregate: implement codespeed JSON output", 2018-01-05), but since the "run" scripts uses "GIT_TEST_INSTALLED" internally this was only ever useful for one-off runs of a single revision as all the "environment" values would be ones for whatever directory the "run" script ran last. Let's instead fall back on the "uname -r" case, which is the sort of thing the environment should be set to, not something that duplicates other parts of the codpseed output. For setting the "environment" to something custom the perf.repoName variable can be used. See 19cf57a ("perf/run: read GIT_PERF_REPO_NAME from perf.repoName", 2018-01-05). Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]>
1 parent 9bb8145 commit c43b7e6

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

t/perf/aggregate.perl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,6 @@ sub print_codespeed_results {
312312
$environment = $reponame;
313313
} elsif (exists $ENV{GIT_PERF_REPO_NAME} and $ENV{GIT_PERF_REPO_NAME} ne "") {
314314
$environment = $ENV{GIT_PERF_REPO_NAME};
315-
} elsif (exists $ENV{GIT_TEST_INSTALLED} and $ENV{GIT_TEST_INSTALLED} ne "") {
316-
$environment = $ENV{GIT_TEST_INSTALLED};
317-
$environment =~ s|/bin-wrappers$||;
318315
} else {
319316
$environment = `uname -r`;
320317
chomp $environment;

0 commit comments

Comments
 (0)