Skip to content

Commit f0e19cb

Browse files
avargitster
authored andcommitted
Git.pm: add the "use warnings" pragma
Amend Git.pm to load the "warnings" pragma like the rest of the code in perl/ in addition to the existing "strict" pragma. This is considered the bare minimum best practice in Perl. Ever since this code was introduced in b1edc53 ("Introduce Git.pm (v4)", 2006-06-24) it's only been using "strict", not "warnings". This leaves contrib/buildsystems/Generators/{QMake,VCproj}.pm and contrib/mw-to-git/Git/Mediawiki.pm without "use warnings". Amending those would be a sensible follow-up change, but I don't have an easy way to test those so I'm not changing them. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 872ba00 commit f0e19cb

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

perl/Git.pm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ package Git;
99

1010
use 5.008;
1111
use strict;
12+
use warnings;
1213

1314

1415
BEGIN {

0 commit comments

Comments
 (0)