Skip to content

Conversation

@Saibamen
Copy link

@Saibamen Saibamen commented Oct 10, 2024

I cannot create PR in gitgitgadget, because there is no repository for Git for Windows there.

Please change your Pull Request template.

Fixes this warning:
image

@dscho
Copy link
Member

dscho commented Oct 10, 2024

Now testing C:\test\git.exe
git: '' is not a git command. See 'git --help'.

The intention of

("C:\test\git.exe", "", 1 ),
is to verify that running git.exe with an empty argument errors out with exit code 1.

The fact that the logs show the warning might look unwanted to you, but it is very much wanted: it verifies to the reader that Git was run as intended.

In other words, the existing code works as intended, and the code introduced by this PR would not.

@dscho dscho closed this Oct 10, 2024
@Saibamen Saibamen deleted the patch-1 branch October 10, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants