wincred: Avoid memory corruption #5856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wcsncpy_s()` wants to write the terminating null character so we need to allocate one more space for it in the target memory block. This should fix crashes when trying to read passwords. When this happened, the password/token wouldn't print out and Git would therefore ask for a new password every time. Signed-off-by: David Macek <[email protected]>
dscho
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Looks obviously correct to me, the documentation clearly states that the NUL character must be accounted for. Thank you!
@hickford FYI this seems to have been introduced here, maybe you want to verify that there are no similar problems in near-by patches.
|
/add relnote bug A potential memory corruption in the optional The workflow run was started |
github-actions bot
pushed a commit
to git-for-windows/build-extra
that referenced
this pull request
Oct 6, 2025
A potential memory corruption in the optional `wincred` credential helper [was fixed](git-for-windows/git#5856). Signed-off-by: gitforwindowshelper[bot] <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
dscho
added a commit
that referenced
this pull request
Oct 7, 2025
dscho
added a commit
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.