Revert "Cygwin: console: Store console mode only when console is opened"

Unfortunately, reverting d9ebf01 (Cygwin: console: Fix tcsetattr
which was broken sinse cygwin 3.5.5, 2025-04-08) is not enough to
reinstate Ctrl+C behavior during clones via SSH in Git for Windows, it
is also necessary to revert c94808b (Cygwin: console: Store console
mode only when console is opened, 2025-05-07).

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

winsup/cygwin/fhandler/console.cc

@@ -771,8 +771,6 @@ fhandler_console::setup ()
       con.disable_master_thread = true;
       con.master_thread_suspended = false;
       con.num_processed = 0;
-      con.curr_input_mode = tty::restore;
-      con.curr_output_mode = tty::restore;
     }
 }
 
@@ -851,6 +849,11 @@ fhandler_console::set_input_mode (tty::cons_mode m, const termios *t,
 	flags |= ENABLE_PROCESSED_INPUT;
       break;
     }
+  if (con.curr_input_mode != tty::cygwin && m == tty::cygwin)
+    {
+      prev_input_mode_backup = con.prev_input_mode;
+      con.prev_input_mode = oflags;
+    }
   con.curr_input_mode = m;
   SetConsoleMode (p->input_handle, flags);
   if (!(oflags & ENABLE_VIRTUAL_TERMINAL_INPUT)
@@ -890,6 +893,11 @@ fhandler_console::set_output_mode (tty::cons_mode m, const termios *t,
 	flags |= DISABLE_NEWLINE_AUTO_RETURN;
       break;
     }
+  if (con.curr_output_mode != tty::cygwin && m == tty::cygwin)
+    {
+      prev_output_mode_backup = con.prev_output_mode;
+      GetConsoleMode (p->output_handle, &con.prev_output_mode);
+    }
   con.curr_output_mode = m;
   acquire_attach_mutex (mutex_timeout);
   DWORD resume_pid = attach_console (con.owner);
@@ -1829,12 +1837,6 @@ fhandler_console::open (int flags, mode_t)
   handle_set.output_handle = h;
   release_output_mutex ();
 
-  if (con.owner == GetCurrentProcessId ())
-    {
-      GetConsoleMode (get_handle (), &con.prev_input_mode);
-      GetConsoleMode (get_output_handle (), &con.prev_output_mode);
-    }
-
   wpbuf.init ();
 
   handle_set.input_mutex = input_mutex;
@@ -1880,19 +1882,6 @@ fhandler_console::open (int flags, mode_t)
 	setenv ("TERM", "cygwin", 1);
     }
 
-  if (con.curr_input_mode != tty::cygwin)
-    {
-      prev_input_mode_backup = con.prev_input_mode;
-      GetConsoleMode (get_handle (), &con.prev_input_mode);
-      set_input_mode (tty::cygwin, &get_ttyp ()->ti, &handle_set);
-    }
-  if (con.curr_output_mode != tty::cygwin)
-    {
-      prev_output_mode_backup = con.prev_output_mode;
-      GetConsoleMode (get_output_handle (), &con.prev_output_mode);
-      set_output_mode (tty::cygwin, &get_ttyp ()->ti, &handle_set);
-    }
-
   debug_printf ("opened conin$ %p, conout$ %p", get_handle (),
 		get_output_handle ());
 
@@ -4730,7 +4719,7 @@ fhandler_console::cons_mode_on_close (handle_set_t *p)
   NTSTATUS status =
     NtQueryInformationProcess (GetCurrentProcess (), ProcessBasicInformation,
 			       &pbi, sizeof (pbi), NULL);
-  if (NT_SUCCESS (status) && cygwin_pid (con.owner)
+  if (NT_SUCCESS (status)
       && !process_alive ((DWORD) pbi.InheritedFromUniqueProcessId))
     /* Execed from normal cygwin process and the parent has been exited. */
     return tty::cygwin;