-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add url only input option #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add url only input option #54
Conversation
|
It works:
Side note: The action takes a very long time. The issue is created almost immediately, but it keeps running for several minutes after that? My feed is very small, so not sure what's going on. Any idea? |
In git-for-windows#54 an issue was identified where the Action seemed to take a ridiculously long time to process a given feed URL. This new debug configuration makes it easy to single-step through the code while accessing that feed. Signed-off-by: Johannes Schindelin <[email protected]>
I am not exactly sure what is happening, but here are a couple of observations:
|
|
Nice, it completes in 1s now! I've enabled the option to allow edits by maintainers if you want to reset this branch to match yours (otherwise I can do it in a few hours). |
The default e.g. with GitHub Pages seems to be to keep the connection alive, which does not make sense here. Signed-off-by: Johannes Schindelin <[email protected]>
In #54 an issue was identified where the Action seemed to take a ridiculously long time to process a given feed URL. This new debug configuration makes it easy to single-step through the code while accessing that feed. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
This PR adds a
url-onlyinput option. When set totruethe issue body will contain only theitem.link.I additionally separated the inputs by type in the js, if this is not desirable I can revert that.
Lastly, I am not super familiar with node.js github actions, but I believe I had to run the build steps to get it to work as a github action (please let me know if I need to do something different to update dist). Edit: the workflow failed so I guess that answers that, but I don't know what I need to run to get it passing. I ran everything in the
package.jsonalready.Fixes #53