You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest 29 was released in August of 2022 already, so not sure why this wasn't detected by Dependabot earlier. Running an npm outdated locally showed that we were using an older version of Jest.
not sure why this wasn't detected by Dependabot earlier.
I think the reason is the ^ in front of the version number, which according to the package.json documentation means that we need any updates to be "compatible with" this version. According to SemVer, incrementing the major version number is done when the version becomes incompatible.
I think the reason is the ^ in front of the version number, which according to the package.json documentation means that we need any updates to be "compatible with" this version. According to SemVer, incrementing the major version number is done when the version becomes incompatible.
That ^ only applies when running npm update, so it stays within the bounds of the same major version. However, I expected Dependabot to flag this major upgrade in a PR. It also opened a PR to upgrade @typescript-eslint/eslint-plugin from 7.18.0 to 8.4.0, which had the same ^ syntax in the package.json file 🤷🏼♂️
Anyway, thanks for the quick review and the merge!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest 29 was released in August of 2022 already, so not sure why this wasn't detected by Dependabot earlier. Running an
npm outdatedlocally showed that we were using an older version of Jest.