Implement exercise T4L1/view-commits

[SAN-MUYUN]

Exercise Review

Exercise Discussion

#60

Checklist

• If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
• Have you written unit tests using repo-smith to validate the exercise grading scheme?
• Have you tested the download script using test-download.sh?
• Have you verified that this exercise does not already exist or is not currently in review?
• Did you introduce a new grading mechanism that should belong to git-autograder?
• Did you introduce a new dependency that should belong to app?

[woojiahao]

Thank you @SAN-MUYUN for helping to work on this exercise! I've added some comments!

[SAN-MUYUN]

Thanks so much for the feedback! I will make the necessary changes hopefully by next week.

[jovnc]

Hi @SAN-MUYUN , is this PR currently being worked on?

Would be good to get an update by 9 Dec, else we need to close this PR, so that we can resolve this issue. Thanks!

[SAN-MUYUN]

@woojiahao Apologies for the long wait! Apart from the test specs, I have updated the PR accordingly.

I just realised that I cannot pass the verify-tests cases for grocery-shopping as well, it is prompting the same error as #74 despite my repo-smith is updated to v1.0.0.

[jovnc]

@SAN-MUYUN I have verified that the tests passes on my MacOS machine.

[SAN-MUYUN]

@jovnc Thanks for the update! I am using Windows 11 OS. Similar issues have happened before, likely because of how repo-smith handles deletion of temporary folders as mentioned in issue #74 .

[jovnc]

@VikramGoyal23 Would it be possible to help test on a Windows machine as well, and see if the same issue persists? Thanks!

[VikramGoyal23]

OS: Windows 11

All tests are passing.

However, other repos are still throwing permission errors similar to issue #74. Below are branch-bender's tests:

[jovnc]

Other than OS-specific issue with running repo-smith tests, the verification logic and testing LGTM. The OS related issue can be solved separately in a different PR, though I cannot pinpoint exactly what is causing the issue.

@VikramGoyal23 @woojiahao Any thoughts on this? Feel free to merge when ready.

[jovnc]

@SAN-MUYUN I have helped to clean up the test_verify.py to keep only the base files, and also run formatting on the code. Thank you for your contribution @SAN-MUYUN, I think that it is good enough for now, and we can merge this!