-
Notifications
You must be signed in to change notification settings - Fork 26
Implement exercise T6L2/branch-compare #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement exercise T6L2/branch-compare #115
Conversation
|
@lavanyagarg112 Can you mark this pull request as "open" instead of "draft"? |
@VikramGoyal23 Sorry for the delay, just have to fix a few bugs. Will open by the weekend. Thanks! |
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and verification logic LGTM, but some changes are needed so that we can follow conventions in this repository.
Thanks for your contribution @lavanyagarg112, once the changes are made, do ping me for a re-review and we can merge the PR
Sure thank you! Will do by end of today. |
|
Update: can we also update README.md to simply include link to exercise in the website? |
|
Hi @jovnc, I have made the changes, please let me know if there are any more changes to implement. |
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM verification logic and download logic looks great! Thank you @lavanyagarg112 for the contribution!
I will help to do a little cleanup of the code then I'll merge it, thanks!
Exercise Review
Exercise Discussion
#69
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?