Skip to content

Conversation

@lavanyagarg112
Copy link
Contributor

@lavanyagarg112 lavanyagarg112 commented Nov 8, 2025

Exercise Review

Exercise Discussion

#69

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@lavanyagarg112 lavanyagarg112 marked this pull request as draft November 9, 2025 10:27
@woojiahao woojiahao added the exercise review Review a proposed exercise label Nov 10, 2025
@woojiahao woojiahao linked an issue Nov 20, 2025 that may be closed by this pull request
1 task
@VikramGoyal23
Copy link
Collaborator

@lavanyagarg112 Can you mark this pull request as "open" instead of "draft"?

@lavanyagarg112
Copy link
Contributor Author

@lavanyagarg112 Can you mark this pull request as "open" instead of "draft"?

@VikramGoyal23 Sorry for the delay, just have to fix a few bugs. Will open by the weekend. Thanks!

@lavanyagarg112 lavanyagarg112 marked this pull request as ready for review December 7, 2025 15:54
@jovnc jovnc changed the title Implement Exercise T6L2/branch-compare Implement exercise T6L2/branch-compare Dec 12, 2025
@jovnc jovnc self-assigned this Dec 12, 2025
Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and verification logic LGTM, but some changes are needed so that we can follow conventions in this repository.

Thanks for your contribution @lavanyagarg112, once the changes are made, do ping me for a re-review and we can merge the PR

@lavanyagarg112
Copy link
Contributor Author

Tests and verification logic LGTM, but some changes are needed so that we can follow conventions in this repository.

Thanks for your contribution @lavanyagarg112, once the changes are made, do ping me for a re-review and we can merge the PR

Sure thank you! Will do by end of today.

@jovnc
Copy link
Collaborator

jovnc commented Dec 15, 2025

Update: can we also update README.md to simply include link to exercise in the website?

See https://git-mastery.github.io/lessons/branch/exercise-branch-compare.html

@lavanyagarg112 lavanyagarg112 requested a review from jovnc December 15, 2025 12:22
@lavanyagarg112
Copy link
Contributor Author

Hi @jovnc, I have made the changes, please let me know if there are any more changes to implement.

Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM verification logic and download logic looks great! Thank you @lavanyagarg112 for the contribution!

I will help to do a little cleanup of the code then I'll merge it, thanks!

@jovnc jovnc merged commit c8c8696 into git-mastery:main Dec 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussing exercise review Review a proposed exercise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Exercise Discussion] T6L2/branch-compare

4 participants