-
Notifications
You must be signed in to change notification settings - Fork 26
Implement exercise T4L2/tags-add #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MousseDm @woojiahao Opened new PR to help continue implementation of #85 Here are some changes made:
There are some major differences in the verification logic, to ensure that we verify according to the task steps (ensure task 1 is completed before task 2) rather than verifying all at once and returning all comments to users. |
VikramGoyal23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes from my end but otherwise LGTM!
|
@VikramGoyal23 Did some refactoring of the verify logic (so that we verify that first tag is lightweight, and second tag is annotated as well), and also added tests for those Do let me know if any other changes are needed, else we are good to merge this |
VikramGoyal23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Exercise Review
Exercise Discussion
#61
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?