Skip to content

Fix bugs related to Tour 4 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jovnc merged 6 commits into from
Dec 30, 2025
Merged

Fix bugs related to Tour 4 #196

jovnc merged 6 commits into from
Dec 30, 2025

Conversation

@jovnc
Copy link
Collaborator

@jovnc jovnc commented Dec 29, 2025

Exercise Review

Exercise Discussion

#194

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@jovnc jovnc added bug Something isn't working priority.High labels Dec 29, 2025
@jovnc jovnc mentioned this pull request Dec 29, 2025
Open
woojiahao
woojiahao reviewed Dec 29, 2025
View reviewed changes
@jovnc jovnc marked this pull request as ready for review December 29, 2025 12:16
@jovnc jovnc requested a review from VikramGoyal23 December 29, 2025 12:26
This was referenced Dec 30, 2025
Merged
Merged
@jovnc
Copy link
Collaborator Author

jovnc commented Dec 30, 2025

@VikramGoyal23 Can you review these changes, more information can be found in #194 for the issues this fixes.

VikramGoyal23
VikramGoyal23 approved these changes Dec 30, 2025
View reviewed changes
Copy link
Collaborator

@VikramGoyal23 VikramGoyal23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jovnc jovnc merged commit df4d90a into git-mastery:main Dec 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woojiahao woojiahao woojiahao left review comments

@VikramGoyal23 VikramGoyal23 VikramGoyal23 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working priority.High

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jovnc @woojiahao @VikramGoyal23