Skip to content

Fix exercise T4L2/tags-push #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VikramGoyal23 merged 3 commits into from
Jan 1, 2026
Merged

Fix exercise T4L2/tags-push #201

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5100d7
Fix get_remote_tags
VikramGoyal23 Dec 31, 2025
c167712
experiment
VikramGoyal23 Dec 31, 2025
8653d23
Remove print statements
VikramGoyal23 Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tags_push/verify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def get_username() -> Optional[str]:
return run_command(["gh", "api", "user", "-q", ".login"])


def get_remote_tags(username: str) -> List[str]:
raw_tags = run_command(["git", "ls-remote", "--tags"])
def get_remote_tags(username: str, exercise: GitAutograderExercise) -> List[str]:
raw_tags = exercise.repo.repo.git.ls_remote("--tags")
if raw_tags is None:
return []
return [line.split("/")[2] for line in raw_tags.strip().splitlines()]
Expand All @@ -49,7 +49,7 @@ def verify(exercise: GitAutograderExercise) -> GitAutograderOutput:
if username is None:
raise exercise.wrong_answer([IMPROPER_GH_CLI_SETUP])

tag_names = get_remote_tags(username)
tag_names = get_remote_tags(username, exercise)

comments = []

Expand Down