-
Notifications
You must be signed in to change notification settings - Fork 26
Fix inconsistent commit ordering for git log #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the quick fix, @jovnc |
|
@woojiahao I'll rebase against the main branch and test the bot again later |
VikramGoyal23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8582782 to
804784b
Compare
|
@VikramGoyal23 Can you review the added comments? |
|
@woojiahao The comment action only runs on newly created PR, maybe we can test it out in a new PR |
|
It failed again: https://github.com/git-mastery/exercises/actions/runs/20695329443/job/59458055297 I'm starting to suspect it has something to do with the |
ca0e735 to
31db09c
Compare
VikramGoyal23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the comments are sufficient to document the reasoning. Should we make a separate note somewhere else noting that the revision graph is jumbled up without the sleep statement? Or is that intuitive enough for a newcomer?
|
@VikramGoyal23 I'll merge this in first, this is good enough for now, I believe this is good enough for now and can serve as an example to future contributors of such an issue. If we encounter this again in the future, we will be aware of it. |
Exercise Review
Exercise Discussion
Fix #212
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?git-autograder?app?