Skip to content

Conversation

@jovnc
Copy link
Collaborator

@jovnc jovnc commented Jan 4, 2026

Exercise Review

Exercise Discussion

Fix #212

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested your changes using the instructions posted?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@jovnc jovnc requested a review from VikramGoyal23 January 4, 2026 15:45
@jovnc jovnc added bug Something isn't working priority.High labels Jan 4, 2026
@jovnc jovnc changed the title [hands-on] Add time.sleep(1) to relevant hands-on Fix inconsistent commit ordering for git log Jan 4, 2026
@jovnc jovnc mentioned this pull request Jan 4, 2026
@damithc
Copy link
Contributor

damithc commented Jan 4, 2026

Thanks for the quick fix, @jovnc
We probably want to document the rationale for this 'odd' behaviour somewhere (as a comment?)

@jovnc
Copy link
Collaborator Author

jovnc commented Jan 5, 2026

@woojiahao I'll rebase against the main branch and test the bot again later

Copy link
Collaborator

@VikramGoyal23 VikramGoyal23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jovnc jovnc force-pushed the fix/commit-ordering branch from 8582782 to 804784b Compare January 5, 2026 10:48
@jovnc
Copy link
Collaborator Author

jovnc commented Jan 5, 2026

@VikramGoyal23 Can you review the added comments?

@jovnc
Copy link
Collaborator Author

jovnc commented Jan 5, 2026

@woojiahao The comment action only runs on newly created PR, maybe we can test it out in a new PR

@woojiahao
Copy link
Member

It failed again: https://github.com/git-mastery/exercises/actions/runs/20695329443/job/59458055297

I'm starting to suspect it has something to do with the GITHUB_TOKEN because it works when I create the PR

@woojiahao woojiahao force-pushed the fix/commit-ordering branch from ca0e735 to 31db09c Compare January 5, 2026 12:41
Copy link
Collaborator

@VikramGoyal23 VikramGoyal23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the comments are sufficient to document the reasoning. Should we make a separate note somewhere else noting that the revision graph is jumbled up without the sleep statement? Or is that intuitive enough for a newcomer?

@jovnc
Copy link
Collaborator Author

jovnc commented Jan 5, 2026

@VikramGoyal23 I'll merge this in first, this is good enough for now, I believe this is good enough for now and can serve as an example to future contributors of such an issue. If we encounter this again in the future, we will be aware of it.

@jovnc jovnc merged commit 26f9233 into git-mastery:main Jan 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority.High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hands-On] Inconsistent commit ordering for git log

4 participants