Fix contribution message workflow permission issue on PR from fork #224
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
pull_requesttrigger type is forced for PRs that come from forks to only havereadpermission for all scopes regardless of what we set explicitly in the workflow -> results in permission issue in contribution commentSource: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflows-in-forked-repositories
Proposed solution:
pull_request_targetwith restricted scope for GITHUB_TOKENSource: https://www.linkedin.com/pulse/how-access-secrets-running-tests-forked-pull-requests-kylee-fields-7vcne/
Note: this change will only take effect for PRs that appear AFTER this PR is merged.
Alternative solution:
pull_requesttrigger that builds relevant artifacts (if needed), then useworkflow_runstrigger to comment to github (see more here: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/)