Skip to content

Comments

Create fork-repo exercise#26

Merged
woojiahao merged 4 commits intomainfrom
fork-repo
Aug 3, 2025
Merged

Create fork-repo exercise#26
woojiahao merged 4 commits intomainfrom
fork-repo

Conversation

@woojiahao
Copy link
Member

@woojiahao woojiahao commented Aug 3, 2025

Exercise Review

Exercise Discussion

Exercise for #24

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?

  • Have you written unit tests using repo-smith to validate the exercise grading scheme?

  • Have you tested the download script using test-download.sh?

  • Have you verified that this exercise does not already exist or is not currently in review?

  • Did you introduce a new grading mechanism that should belong to git-autograder?

    Yes, but that is work pending

  • Did you introduce a new dependency that should belong to app?

    No

This isn't representative of typical exercises as there was no existing
tooling for verifying remote calls like this. However, this serves as a
good baseline for understanding how unit tests can be constructed for
Git-Mastery
@woojiahao woojiahao requested a review from damithc August 3, 2025 15:54
@woojiahao woojiahao self-assigned this Aug 3, 2025
@woojiahao woojiahao added the exercise review Review a proposed exercise label Aug 3, 2025
@woojiahao
Copy link
Member Author

This is an example of the CI built for validating Git-Mastery exercises

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a conventional unit test because we don't currently support unit testing these "remote" checks. So we're mocking the function calls which works well for us, but there's a lot of additional scaffolding that we can introduce down the line. Not blocking for now

@woojiahao woojiahao merged commit a684151 into main Aug 3, 2025
2 checks passed
@woojiahao woojiahao deleted the fork-repo branch August 3, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussing exercise review Review a proposed exercise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants