Skip to content

Conversation

@VikramGoyal23
Copy link
Collaborator

Exercise Review

Exercise Discussion

#63

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@VikramGoyal23
Copy link
Collaborator Author

The tests are implemented entirely through mocking due to the unique nature of the exercise.

@VikramGoyal23
Copy link
Collaborator Author

Fixes #63

@damithc damithc linked an issue Nov 2, 2025 that may be closed by this pull request
1 task
@woojiahao woojiahao added the exercise review Review a proposed exercise label Nov 10, 2025
@woojiahao woojiahao self-assigned this Nov 20, 2025
Copy link
Member

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but overall, the exercise structure makes sense!

@VikramGoyal23
Copy link
Collaborator Author

Thanks for the feedback. I should hopefully resolve these issues within the next 1-2 days.

@VikramGoyal23
Copy link
Collaborator Author

@woojiahao Could you review my changes?

Copy link
Member

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit for formatting. The change I've suggested might affect the unit tests, so it will be good to verify that.

Could you re-run the ./test-download.sh tags-push script to ensure that all the tags have the right message?

@VikramGoyal23
Copy link
Collaborator Author

I've fixed the formatting issue and done the necessary checks- the unit tests pass and the tags have the correct message.

Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nits on coding standard and abstraction. The verify logic seems right to me.

Copy link
Collaborator

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nits on download.py and I think we can merge this PR

- Added instructions to README
- Removed hacks and cleaned up download.py
- Removed GH API call
- Cleaned up test_verify.py
- Added new test
@jovnc
Copy link
Collaborator

jovnc commented Dec 16, 2025

@VikramGoyal23 I have helped to clean up the code using ruff format, and handled a type linting error in get_remote_tags, and also updated README to follow new format. LGTM and will be merging this PR!

@jovnc jovnc merged commit acc944a into git-mastery:main Dec 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Exercise Discussion] T4L2/tags-push

3 participants