-
Notifications
You must be signed in to change notification settings - Fork 26
Implement exercise T4L2/tags-push #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The tests are implemented entirely through mocking due to the unique nature of the exercise. |
|
Fixes #63 |
woojiahao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but overall, the exercise structure makes sense!
|
Thanks for the feedback. I should hopefully resolve these issues within the next 1-2 days. |
|
@woojiahao Could you review my changes? |
woojiahao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit for formatting. The change I've suggested might affect the unit tests, so it will be good to verify that.
Could you re-run the ./test-download.sh tags-push script to ensure that all the tags have the right message?
|
I've fixed the formatting issue and done the necessary checks- the unit tests pass and the tags have the correct message. |
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor nits on coding standard and abstraction. The verify logic seems right to me.
jovnc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor nits on download.py and I think we can merge this PR
- Added instructions to README - Removed hacks and cleaned up download.py - Removed GH API call - Cleaned up test_verify.py - Added new test
b0cb09e to
5041b1d
Compare
|
@VikramGoyal23 I have helped to clean up the code using |
Exercise Review
Exercise Discussion
#63
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?