small-and-fast: recreate the diagrams using chart.js #1889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagrams showing just how much faster Git performs than Subversion were originally created using the Google Charts API, in b6d341c (first graphs and new services, 2012-04-30). In the meantime, the Google Charts API joined so many other things in the Google Graveyard (see https://killedbygoogle.com/ for more details). This means that the diagrams 404ed, and users were left wondering what should have been demonstrated on this page. But when a door closes, another door opens, and there are wonderful contenders in this time and age, and we do not even have to display static images, we can switch to proper, Javascript-backed charts where you can even hover over the chart and see the exact number! So let's do that. Based on https://www.chartjs.org/, reimplement those charts. That also offers a wildly improved readability of the entire thing, compared to the somewhat cryptic Google Chart URLs. This fixes git#1862. Signed-off-by: Johannes Schindelin <[email protected]>
|
I don't really like to bring in a client side library to render some bar charts we can render statically instead. Currently I'm experimenting with another idea. I'll let you know if it works out. |
|
Superseded by #1894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Recreate the currently broken diagrams on the "About - Small and Fast" page using
chart.js.Context
When the Google Charts API entered the Google Graveyard, the diagrams on the "About - Small and Fast" page got broken.
This fixes #1862.
As a bonus, this allows readers to see the actual numbers when hovering over the bars: