Skip to content

Rename "Downloads" to "Install" and redesign #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

Rename "Downloads" to "Install" and redesign #2096

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e9ea73
Move /download to /install
jvns Oct 1, 2025
a2574df
install page: add new "Build from source" page
jvns Oct 1, 2025
e6cb1d1
install page: Rename 'downloads" to "install" in sidebar and homepage
jvns Oct 1, 2025
c755b09
install page: Automatically link to correct OS directions
jvns Oct 1, 2025
383c696
install page: remove "build from source" note on Linux/Mac
jvns Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions layouts/partials/sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,7 @@
<a href="{{ relURL "docs" }}"{{ if or (eq .Params.Subsection "reference") (eq .Params.Subsection "manual") }} class="active"{{ end }}>Reference</a>
</li>
<li>
<a href="{{ relURL "downloads" }}"{{ if (eq $section "downloads") }} class="active"{{ end }}>Downloads</a>
<ul {{ if (eq $section "downloads") }}class="expanded"{{ end }}>
<li>
<a href="{{ relURL "downloads/logos" }}"{{ if (eq .Params.Subsection "logos") }} class="active"{{ end }}>Logos</a>
</li>
</ul>
<a href="{{ relURL "install" }}"{{ if (eq $section "install") }} class="active"{{ end }}>Install</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the reason why the Playwright tests fail now...

Error: expect.not.toHaveClass: Error: strict mode violation: getByRole('link', { name: 'All' }) resolved to 2 elements:
    1) <a class="install-link" href="http://localhost:5000/install/win">Install</a> aka getByRole('link', { name: 'Install' })
    2) <a href="#" data-os="" class="subtle-button gui-os-filter">All</a> aka getByRole('link', { name: 'All', exact: true })

Call log:
  - Expect "not toHaveClass" with timeout 5000ms
  - waiting for getByRole('link', { name: 'All' })


  66 |
  67 |     const allButton = page.getByRole('link', { name: 'All' })
> 68 |     await expect(allButton).not.toHaveClass(/selected/)
     |                                 ^
  69 |
  70 |     const thumbnails = page.locator('.gui-thumbnails li:visible')
  71 |     const count = await thumbnails.count()
    at /home/runner/work/git-scm.com/git-scm.com/tests/git-scm.spec.js:68:33

We probably need to change this line:

    const allButton = page.getByRole('link', { name: 'All' })

to use an exact match:

    const allButton = page.getByRole('link', { name: 'All', exact: true })

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for looking into that, will try that fix!

</li>
<li>
<a href="{{ relURL "community" }}"{{ if (eq $section "community") }} class="active"{{ end }}>Community</a>
Expand Down
4 changes: 2 additions & 2 deletions layouts/partials/site-root.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ <h3>Reference</h3>
</a>
</li>
<li>
<a href="{{ relURL "downloads" }}">
<a href="{{ relURL "install" }}">
<img src="{{ relURL "images/icons/fa-down-long.svg" }}" width="74" height="74" />
<h3>Downloads</h3>
<h3>Install</h3>
<p>Binary releases for all major platforms.</p>
</a>
</li>
Expand Down