-
Notifications
You must be signed in to change notification settings - Fork 1.3k
update mac download details #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kerhac
wants to merge
2
commits into
git:gh-pages
Choose a base branch
from
kerhac:gh-pages
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−3
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that was quite the consensus of #1774, so I am loathe to accept that explanation as-is.
The conversation in that ticket concluded with no definitive decision as to which binary package to recommend, but XCode was suggested as a replacement only by @timcharper.
However, it is frustratingly hard (and apparently impossible) to say for sure which Git version XCode's Command Line Tools include. The release notes certainly keep everyone in the dark!
Therefore, I do not want to merge this as-is. I want a more nuanced description here. It should at least mention that most developers opt to use Homebrew. It looks as if even GitHub Actions' hosted macOS runners ship a different Git version than XCode's (this update down-grades Git while leaving the XCode Command Line Tools unchanged, suggesting that the former is not included in the latter).