fixed/Build from Source’ tab partially hidden in mobile view on Install page #2106 #2108
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,9 +42,11 @@ | |
|
|
||
| @media (max-width: $mobile-m) { | ||
| a[role="tab"] { | ||
| padding: .5rem .25rem; | ||
| font-size: 0.75rem; | ||
|
Collaborator
There was a problem hiding this comment. It's arguable, but I think it's too small. I rather have you drop this line out. |
||
| line-height: 1.2em; | ||
| display: flex; | ||
| flex: 1; | ||
|
Collaborator
There was a problem hiding this comment. @kushkumarkashyap7280 This makes the tab buttons grow on semi-small screens: 
vs the old 
Is that intentional? On large'ish screen we always show tab buttons that fit the contentd; 
Why have them grow on mobile? As far as I can tell, it has no effect on the issue you're trying to fix. |
||
|
|
||
| span { | ||
| margin: auto; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is all we need.
Until you want to take it one step further and support really narrow screens. But in that case I suggest we work on putting
flex-direction: columnon.install-tabs, so we have vertical tabs. But there's more work to be done to have it look nicely, because for example round corners aren't okay:(and it would also be better to not have "Install" and "Latest version" side-by-side.