Skip to content

fix: apply noUncheckedIndexedAccess true #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: apply noUncheckedIndexedAccess true #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
697271c
add noUncheckedIndexedAccess to tsconfig
tsukuha Jun 13, 2024
10e4d49
apply noUncheckedIndexedAccess to nuxt-icon.vue
tsukuha Jun 13, 2024
2866422
fix: add await
tsukuha Nov 7, 2024
d5a5232
fix: remove await
tsukuha Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/runtime/components/nuxt-icon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,14 @@ async function getIcon () {
as: 'raw',
eager: false
})
const rawIcon = await iconsImport[`/assets/icons/${props.name}.svg`]()
const rawIconImport = iconsImport[`/assets/icons/${props.name}.svg`]
if (!rawIconImport) {
console.error(
`[nuxt-icons] Icon '${props.name}' doesn't exist in 'assets/icons'`
)
return
}
const rawIcon = await rawIconImport()
if (rawIcon.includes('stroke')) { hasStroke = true }
icon.value = rawIcon
} catch {
Expand Down
5 changes: 4 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"extends": "./playground/.nuxt/tsconfig.json"
"extends": "./playground/.nuxt/tsconfig.json",
"compilerOptions": {
"noUncheckedIndexedAccess": true
}
}