-
Notifications
You must be signed in to change notification settings - Fork 725
UI fixes #11468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
UI fixes #11468
Conversation
|
@mathijs81 is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses three UI/UX issues by adding drag-and-drop support to the commit details panel, making commit titles clickable to edit them, and fixing a state management bug in the forge factory that caused incorrect GitHub integration prompts when switching repositories.
- Adds drop zone support to the expanded commit details view for amending/squashing commits
- Makes commit titles clickable to enter edit mode, improving discoverability
- Fixes
_determinedForgeTypestate not resetting when switching repos
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/desktop/src/lib/forge/forgeFactory.svelte.ts | Resets _determinedForgeType to 'default' when no repo/baseBranch exists, fixing incorrect forge integration prompts |
| apps/desktop/src/lib/commits/dropHandler.ts | Extracts drop handler creation logic into reusable createCommitDropHandlers helper function |
| apps/desktop/src/components/StackView.svelte | Wraps commit details view in Dropzone component to enable drag-and-drop for amending/squashing commits |
| apps/desktop/src/components/CommitView.svelte | Adds onclick handler to CommitTitle to enable clicking for edit mode |
| apps/desktop/src/components/CommitTitle.svelte | Adds clickable styling, onclick handler, role="button", and keyboard navigation support |
| apps/desktop/src/components/BranchCommitList.svelte | Refactors to use new createCommitDropHandlers helper, reducing code duplication |
| apps/desktop/cypress/e2e/support/mock/backend.ts | Adds amendCommit mock method to support E2E testing of amend functionality |
| apps/desktop/cypress/e2e/commitActions.cy.ts | Adds E2E test verifying drag-and-drop from uncommitted changes to commit drawer |
|
@mathijs81 thank you for the PR!
Let’s move this item to a separate PR because it’s not about fixing a bug but adding a new feature. |
When switching from a github repo to a non-github repo you still get the `UnassignedViewForgePrompt` because the _determinedForgeType didn't get updated.
|
I moved the commit title change to a different PR. |
🧢 Changes
I fixed 3 UI/UX issues I encountered: