Be oh-so-inclusive with the review terminology#12372
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
bot
added
rust
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase terminology from "PR" (Pull Request) to "review" to be inclusive of both GitHub Pull Requests and GitLab Merge Requests. The changes ensure that users of both platforms are treated equally in the user-facing messages and API.
Changes:
- Renamed
PrMessagetype toForgeReviewMessageandparse_pr_messagefunction toparse_review_message - Renamed
create_prfunction tocreate_review - Updated error messages, user prompts, and documentation to use "review" or "forge review" instead of "PR"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/but/src/lib.rs | Updated function calls and error messages to use "review" terminology instead of "PR" |
| crates/but/src/command/legacy/forge/review.rs | Renamed core types and functions from PR-specific names to review-generic names, updated user-facing messages and authentication error messages to be forge-specific |
| crates/but/src/args/mod.rs | Updated command documentation to clarify support for both PRs and MRs |
| /// Create a new forge review for a branch. | ||
| /// If no branch is specified, prompts the user to select one. | ||
| /// If there is only one branch without a PR, asks for confirmation. | ||
| /// If there is only one branch without a an acco, asks for confirmation. |
There was a problem hiding this comment.
Typo in the comment: "a an acco" appears to be incomplete text. This should likely read "a forge review" or "an associated review" to match the PR's terminology update.
| /// If there is only one branch without a an acco, asks for confirmation. | |
| /// If there is only one branch without an associated review, asks for confirmation. |
| anyhow::bail!("Azure is unsupported at the minute. Sorry 😞."); | ||
| } | ||
| but_forge::ForgeName::Bitbucket => { | ||
| anyhow::bail!("Azure is unsupported at the minute. Sorry 😞."); |
There was a problem hiding this comment.
Copy-paste error: The error message says "Azure is unsupported" but this is the Bitbucket branch. It should say "Bitbucket is unsupported at the minute. Sorry 😞."
| anyhow::bail!("Azure is unsupported at the minute. Sorry 😞."); | |
| anyhow::bail!("Bitbucket is unsupported at the minute. Sorry 😞."); |
Since we support both PRs and MRs, use the term review instead of PRs. GitLab butizens have the same rights as we do.
estib-vega
force-pushed
the
inclusive-review-naming
branch
from
cf1d05a to
d32e350
Compare
1 participant
Since we support both PRs and MRs, use the term review instead of PRs.
GitLab butizens have the same rights as we do.