fix(sync-button): prevent time-ago casing flicker#12373
Merged
PavelLaptev merged 1 commit intomasterfrom Feb 16, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI flicker issue in the SyncButton component where the timestamp briefly appears in lowercase before being capitalized. The root cause was CSS-based capitalization (::first-letter transform) which can render after the initial paint during hydration, causing a visible flash.
Changes:
- Added an optional
capitalizeprop to the TimeAgo component with string-level capitalization logic - Updated SyncButton to use the new
capitalizeprop instead of CSS-based capitalization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ui/src/lib/components/TimeAgo.svelte | Added optional capitalize prop and formatText function to handle string-level capitalization |
| apps/desktop/src/components/SyncButton.svelte | Removed CSS capitalize class and passed capitalize={true} to TimeAgo component |
PavelLaptev
force-pushed
the
feat/timeago-capitalize-flicker
branch
from
b87c1ab to
c0dd295
Compare
PavelLaptev
force-pushed
the
feat/timeago-capitalize-flicker
branch
from
c0dd295 to
6787a25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a UI flicker where the sync timestamp briefly rendered in lowercase and then appeared capitalized.
Root Cause
The text from TimeAgo is lowercase by design, while SyncButton was applying capitalization via CSS (first-letter transform). During render/hydration updates, lowercase content could paint before the style transform became visible.