Re-add HexHash to Request struct for create_reference call (#12354)#12377
Merged
Byron merged 1 commit intogitbutlerapp:masterfrom Feb 16, 2026
Merged
Re-add HexHash to Request struct for create_reference call (#12354)#12377Byron merged 1 commit intogitbutlerapp:masterfrom
HexHash to Request struct for create_reference call (#12354)#12377Byron merged 1 commit intogitbutlerapp:masterfrom
Conversation
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
…tlerapp#12354) This was changed by accident, and a way to prevent such mistakes in future would be to not add serde support to `gix` types.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where creating a branch from a commit in the UI always failed with a deserialization error. The issue was caused by accidentally using gix::ObjectId directly in the API request struct instead of the HexHash wrapper type.
Changes:
- Re-added the
HexHashwrapper type for thecommit_idfield in theAnchor::AtCommitvariant - Added the necessary import for
HexHashfromcrate::json - Updated the conversion to explicitly call
.into()to convertHexHashtogix::ObjectId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was changed by accident, and a way to prevent such mistakes in future would be to not add serde support to
gixtypes.Fixes #12354.