refactor clone for clarity #4849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
Caleb-T-Owens
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers an alternative implementation for
git_clone_repositorywhich is closer to the original vision on how the API should be used.The main issue was the need to turn everything into a frontend
Errorwhich could only convert fromanyhow::Error. This is for good reason,but in this case it was in the way resolved with an
UnmarkedErrorwhich can convert from any other error, while serializing such that the frontend can handle it.Motivation
I used this the
git2version of the code along with thegitoxideversion as an example in my upcoming GitMerge talk for how much simplergit2can be, in the real world, but couldn't resist to try to turn it into the 'best possible version of itself'.