Fix commting with one stack #7902
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
FYI @Byron |
There was an issue where the parents of the workspace commit are not always up to date. While this is something we seperatly need to fix, it also makes sense to move to something more reliable. (And also reduce the amount of forking in the function). As such, I've switched it to always use the multi-branch case
Caleb-T-Owens
force-pushed
the
fix-commiting-with-one-stack
branch
from
4522b22 to
0714310
Compare
|
The test-failure seems to be flake, and I have seen that too in other PR. Now I think it's time to fix the likely source of the issue, and finish GitoxideLabs/gitoxide#1851 which will remove parallel iteration support. |
There was a problem hiding this comment.
While GitoxideLabs/gitoxide#1851 is waiting for CI to be merged, I am rerunning CI here and merging it assuming it will go through this time.
The likely gitoxide fix will then be coming in with #7902.
This brings in a fix to the way references are sorted, assuring they always come out in the right order. Maybe this fixes the flakiness issue. If not, maybe it's something else though?
|
Hey @Byron, Here is a bit of a fuller explanation as to why I made this change. (I wrote this explanation two times already and v3 deleted them so I gave up and just pushed). We were getting what seemed to be this out-of-sync error. As it turns out, there are some cases where we're not calling While we obviously need to tighten up where we call It also removed a code branch which makes everyone happy. |
No description provided.