Add Cypress component test for MessageEditor #9365
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some dependence on reactive variables in favor of using svelte stores, meaning we should not use $effect in any .svelte.ts constructors. Without effects we no longer have lifecycle management, so we never unsubscribe from dependencies. This isn't ideal, but it's also realistically not an immediate issue. The benefit of this is we can easily create component tests using Cypress, and necessary to the `CommitMessageEditor` tests I have been working on.
This further enables component testing with Cypress.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
;stores and removing $effect usage in .svelte.ts constructors.