-
Notifications
You must be signed in to change notification settings - Fork 662
feat: add Default terminal setting & Open in terminal menu #9719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add Default terminal setting & Open in terminal menu #9719
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@peaklabs-dev is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
@peaklabs-dev thank you for the PR :-) ![]() |
465789d
to
714bbe9
Compare
@peaklabs-dev Is this still something we want to merge right? |
@PavelLaptev Yes, but I'm not sure how to implement this for Linux and Windows. Also, should we switch to opening the app for code editors as well instead of links, to allow custom app selection? |
#[cfg(target_os = "macos")] | ||
{ | ||
use std::process::Command; | ||
Command::new("open") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If open::with_command(…)
would be used instead, I think this would be portable provided viable app-names. The .app
suffix on MacOS also wouldn't be needed then, I think
Generally I think it would be OK to start supporting MacOS and add Windows/Linux later. This probably would be gated where the available app-names are configured.
I see. Yes, it would be nice to handle it for all platforms.
What do you mean? |
ToDo & Limitations
🧢 Changes
General
settings pageOpen in Terminal
to project menu which opens the current project in the default terminalPreview
Settings
Menu