-
Notifications
You must be signed in to change notification settings - Fork 665
V3 apply/unapply #9878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Byron
wants to merge
4
commits into
gitbutlerapp:master
Choose a base branch
from
Byron:next
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
V3 apply/unapply #9878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
I.e. if stacks are separate when looking at the workspace, they should remain separtate when one of these is checked out directly.
The idea is to develop both at the same time so it's easier to test that 'unapply' truly goes back to the (mostly) original state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With stashing available, a single-branch aware version of branch apply and unapply is possible.
Follow-up of #9874.
Tasks
but_workspace::checkout()
but-graph
issueShortcomings
Notes
General Rules
This is as conflicts are currently hidden from view.
apply
is doing something, thenunapply
undoes exactly that, or in other wordsState + apply + unapply == State
commit()
currently can't.uncommit()
as well to all apply-unapply tests so these can later be re-tested with different behaviour.Follow-Ups
Thus:
This is a problem, but we can't have conflicts as the UI doesn't show them right now, nor does it allow interacting with them.
Unapply
apply
just to be able to handle them.Research
Unapply: Assignments - with stashing
However, the user should be able to interact with these.
Unapply: Assignments - with WIP commit
Unapply with worktree changes
Possible Follow-Ups